Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: npmjs sigstore tuf: use ValidFor.Start and ValidFor.End #757

Open
ramonpetgrave64 opened this issue Apr 16, 2024 · 1 comment
Open

Comments

@ramonpetgrave64
Copy link
Contributor

The work in #731 retrieves the latest the signing key from the TUF root. There is metadata for a ValidFor.Start, and in the future there may be a ValidFor.End.

Consider ensuring that the current timestamp is between the start and end timestamps.

@ramonpetgrave64
Copy link
Contributor Author

The keys in the TUF root has been rotated and now include an end date.

Newer attestations seem to be using the new key, and the older slsa-verifier v2.5.1 with the hard-coded key no longer works on these newer attestations.

ramonpetgrave64 added a commit to slsa-framework/example-package that referenced this issue Jan 31, 2025
fixes npmjs e2e due to a stale key.

Re: slsa-framework/slsa-github-generator#4078 (comment)

- slsa-framework/slsa-verifier#757 (comment)

Signed-off-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant