Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GCB verification #221

Open
17 of 23 tasks
laurentsimon opened this issue Aug 17, 2022 · 3 comments
Open
17 of 23 tasks

Improve GCB verification #221

laurentsimon opened this issue Aug 17, 2022 · 3 comments
Labels
area:gcb Issue with the gcb verifier type:feature New feature request
Milestone

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Aug 17, 2022

@laurentsimon laurentsimon changed the title Verify GCB provenance's additional header Improve GCB tests Aug 18, 2022
@laurentsimon laurentsimon changed the title Improve GCB tests Improve GCB verification Aug 19, 2022
@ianlewis ianlewis added type:feature New feature request area:gcb Issue with the gcb verifier labels Nov 25, 2022
@laurentsimon laurentsimon added this to the GCB support milestone Dec 5, 2022
@laurentsimon laurentsimon removed this from the GCB support milestone Jan 12, 2023
@laurentsimon laurentsimon added this to the GCB artifacts milestone Mar 21, 2023
@laurentsimon
Copy link
Contributor Author

@asraa I think you landed some of the features in the check list above, correct?

@asraa
Copy link
Contributor

asraa commented Mar 21, 2023

Just checked one more off - the remaining e2e test items that could be improved (like checking to ensure the container builds are fresh) are here: slsa-framework/example-package#149

@laurentsimon
Copy link
Contributor Author

  • Improve regression tests. I tried using us-west2-docker.pkg.dev/slsa-tooling/example-package-repo/e2e-gcb-tag-main-annotated-slsa3@sha256:87db6d5226440e72f7134b71163df45282127a3f7b0600c946683cb2f43a70a9 in function Test_runVerifyGCBArtifactImage. I used crane manifest $IMAGE but the hash calculation does not match: it outputs d8e178223968fd3f4a95826978796e6cb49ed67cb323625dc582475692ee5c7a instead of 87db6d5226440e72f7134b71163df45282127a3f7b0600c946683cb2f43a70a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gcb Issue with the gcb verifier type:feature New feature request
Projects
None yet
Development

No branches or pull requests

3 participants