Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schedule events #3

Open
ianlewis opened this issue Jun 2, 2023 · 2 comments
Open

Support schedule events #3

ianlewis opened this issue Jun 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ianlewis
Copy link
Member

ianlewis commented Jun 2, 2023

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

I don't recall the reason why they were excluded. Was there some info missing from those events that we cared about?

/cc @MarkLodato @laurentsimon @kpk47

@MarkLodato
Copy link
Member

I suspect the reason was to avoid any ambiguity about which specific version was built. While the GITHUB_SHA and GITHUB_REF are set to the default branch, it seems conceivable that builds check out arbitrary branches during the workflow. Then again, it's possible to do that for the other events too.

I have no objection to adding it. It seems that the semantics are reasonably clear.

@ianlewis
Copy link
Member Author

ianlewis commented Jun 2, 2023

Right. I think schedule events are triggered on the default branch at HEAD so we would be presuming it was built from there but I think you're right it's not unlikely that someone would build from an arbitrary commit. However, from a technical perspective this is the same as how all other events work.

I just ran into this as part of tests, so there isn't an end user need for this yet. I'll let it stew a bit before sending a PR to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants