New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable GCB verification for older version #130

Open

laurentsimon opened this issue Jan 11, 2023 · 3 comments

Labels

Collaborator

laurentsimon commented Jan 11, 2023

We currently only verify at HEAD https://github.com/slsa-framework/example-package/blob/main/.github/workflows/scripts/e2e.gcb.default.verify.sh#L17

Collaborator

asraa commented Mar 9, 2023

We enable for v2+, which is where support started.

Right now it's v2.1 to include the git+, but we can backport that to v2.0

Collaborator Author

laurentsimon commented Mar 9, 2023

Given it's a simple fix, is it worth backporting?

Collaborator

asraa commented Mar 9, 2023

I filed an issue, yes
slsa-framework/slsa-verifier#520

ianlewis added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment