refactor: useVueLogger now accepts logLevel

slipmatio · Nov 14, 2024 · f1a99bc · f1a99bc
1 parent 58b59e9
commit f1a99bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -2,6 +2,7 @@
 
 ### 0.3.0 - 2024-11-14
 
+- refactor: changed `useVueLogger` to accept logLevel argument
 - ci: only release after tests pass
 - chore: upgrade Renovate config
 - chore: bump deps

diff --git a/src/index.ts b/src/index.ts
@@ -171,13 +171,12 @@ const useLogger = (name?: string, debug: boolean = false): Logger => {
   })
 }
 
-const useVueLogger = (name?: string, debug: boolean = false): Logger => {
-  let level = LogLevel.INFO
-  if (debug) {
-    level = LogLevel.DEBUG
+const useVueLogger = (name?: string, level?: LogLevel): Logger => {
+  if (!level) {
+    level = import.meta.env.MODE === 'development' ? LogLevel.INFO : LogLevel.ERROR
   }
   return new Logger({
-    logLevel: import.meta.env.MODE === 'development' ? level : LogLevel.ERROR,
+    logLevel: level,
     logFn: VueLogFn,
     name: name,
   })

diff --git a/tests/unit/vue.spec.ts b/tests/unit/vue.spec.ts
@@ -111,13 +111,13 @@ describe('Vue logger', () => {
   })
 
   it('works with useLogger', () => {
-    const mylogger = useVueLogger()
+    const mylogger = useVueLogger('test', LogLevel.INFO)
     mylogger.log('hello vue')
     expect(consoleOutput.length).toBe(1)
   })
 
   it('sets options correctly', () => {
-    const mylogger = useVueLogger()
+    const mylogger = useVueLogger('test', LogLevel.INFO)
 
     mylogger.debug('hello vue')
     expect(consoleOutput.length).toBe(0)