Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating examples #11

Open
thonic opened this issue Apr 27, 2017 · 1 comment
Open

Updating examples #11

thonic opened this issue Apr 27, 2017 · 1 comment

Comments

@thonic
Copy link

thonic commented Apr 27, 2017

Hi, I just wanted to ask which parts of the examples "need to be updated":

def demo(seed=None):
    """
    Create a discrete time Hawkes model and generate from it.
    :return:
    """
raise NotImplementedError("This example needs to be updated.")

from

/examples/inference/standard_bfgs_demo.py

and other files.

Thanks in advance.

@slinderman
Copy link
Owner

Hi @thonic, thanks for reminding me about this. I changed the constructor signature last year and I never got around to backporting it to the BFGS/GD/SGD examples. It only required some minor changes to get bfgs back up and running. Unfortunately, this demo is still not as nice as the discrete and continuous demos in the examples directory.

See 279fbb4

I'll leave this open until I can clean up the other examples too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants