From b915168bee8fcd167ba7f5747da68d411770be92 Mon Sep 17 00:00:00 2001
From: Steven Liekens <steven.liekens@gmail.com>
Date: Sat, 7 Dec 2024 21:33:50 +0100
Subject: [PATCH] Clarify the Offhand situation

---
 GW2SDK/CompatibilitySuppressions.xml | 84 ++++++++++++++++++++++++++++
 GW2SDK/Features/Hero/Offhand.cs      |  8 +--
 2 files changed, 88 insertions(+), 4 deletions(-)

diff --git a/GW2SDK/CompatibilitySuppressions.xml b/GW2SDK/CompatibilitySuppressions.xml
index c2a67215f..52d3842de 100644
--- a/GW2SDK/CompatibilitySuppressions.xml
+++ b/GW2SDK/CompatibilitySuppressions.xml
@@ -442,4 +442,88 @@
     <Right>lib/netstandard2.0/GW2SDK.dll</Right>
     <IsBaselineSuppression>true</IsBaselineSuppression>
   </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
 </Suppressions>
\ No newline at end of file
diff --git a/GW2SDK/Features/Hero/Offhand.cs b/GW2SDK/Features/Hero/Offhand.cs
index 172dfe239..7ae01cc6c 100644
--- a/GW2SDK/Features/Hero/Offhand.cs
+++ b/GW2SDK/Features/Hero/Offhand.cs
@@ -9,15 +9,15 @@ namespace GuildWars2.Hero;
 [JsonConverter(typeof(OffhandJsonConverter))]
 public enum Offhand
 {
-    /// <summary>Nothing in the offhand (empty).</summary>
+    /// <summary>The skill is selected when there is no other skill in the same palette for the current offhand weapon.</summary>
     None,
 
-    /// <summary>Nothing in the offhand (empty).</summary>
+    /// <summary>The skill is selected when the offhand is empty.</summary>
     Nothing,
 
-    /// <summary>A dagger in the offhand.</summary>
+    /// <summary>The skill is selected when a dagger is equipped in the offhand.</summary>
     Dagger,
 
-    /// <summary>A pistol in the offhand.</summary>
+    /// <summary>The skill is selected when a pistol is equipped in the offhand.</summary>
     Pistol
 }