Clarify the Offhand situation

sliekens · Dec 7, 2024 · b915168 · b915168
1 parent 0dca78f
commit b915168
Show file tree

Hide file tree

Showing 2 changed files with 88 additions and 4 deletions.
diff --git a/GW2SDK/CompatibilitySuppressions.xml b/GW2SDK/CompatibilitySuppressions.xml
@@ -442,4 +442,88 @@
     <Right>lib/netstandard2.0/GW2SDK.dll</Right>
     <IsBaselineSuppression>true</IsBaselineSuppression>
   </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net462/GW2SDK.dll</Left>
+    <Right>lib/net462/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net6.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/net8.0/GW2SDK.dll</Left>
+    <Right>lib/net8.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Dagger</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Nothing</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0011</DiagnosticId>
+    <Target>F:GuildWars2.Hero.Offhand.Pistol</Target>
+    <Left>lib/netstandard2.0/GW2SDK.dll</Left>
+    <Right>lib/netstandard2.0/GW2SDK.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
 </Suppressions>
diff --git a/GW2SDK/Features/Hero/Offhand.cs b/GW2SDK/Features/Hero/Offhand.cs
@@ -9,15 +9,15 @@ namespace GuildWars2.Hero;
 [JsonConverter(typeof(OffhandJsonConverter))]
 public enum Offhand
 {
-    /// <summary>Nothing in the offhand (empty).</summary>
+    /// <summary>The skill is selected when there is no other skill in the same palette for the current offhand weapon.</summary>
     None,
 
-    /// <summary>Nothing in the offhand (empty).</summary>
+    /// <summary>The skill is selected when the offhand is empty.</summary>
     Nothing,
 
-    /// <summary>A dagger in the offhand.</summary>
+    /// <summary>The skill is selected when a dagger is equipped in the offhand.</summary>
     Dagger,
 
-    /// <summary>A pistol in the offhand.</summary>
+    /// <summary>The skill is selected when a pistol is equipped in the offhand.</summary>
     Pistol
 }