Exclude obsolete property from 'required' rule

sliekens · Oct 5, 2024 · 4f2bded · 4f2bded
1 parent 24b4578
commit 4f2bded
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/GW2SDK.Tests/PatternsAndPractices/RequireAssignmentTest.cs b/GW2SDK.Tests/PatternsAndPractices/RequireAssignmentTest.cs
@@ -13,14 +13,19 @@ public void Data_transfer_object_members_are_required()
             actual =>
             {
                 Assert.True(
-                    IsRequired(actual),
+                    IsCompliant(actual),
                     $"{actual.DeclaringType?.Name}.{actual.Name} must be read-only or read-write and marked as 'required'."
                 );
             }
         );
 
-        static bool IsRequired(PropertyInfo actual)
+        static bool IsCompliant(PropertyInfo actual)
         {
+            if (actual.CustomAttributes.Any(annotation => annotation.AttributeType == typeof(ObsoleteAttribute)))
+            {
+                return true;
+            }
+
             return !actual.CanWrite
                 || actual.CustomAttributes.Any(
                     annotation => annotation.AttributeType.Name == "RequiredMemberAttribute"