Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chinese character counting error in overview page (#1845) #1846

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Chinese character counting error in overview page (#1845) #1846

wants to merge 3 commits into from

Conversation

HoshinoSuzumi
Copy link

@HoshinoSuzumi HoshinoSuzumi commented Aug 27, 2024 •
edited by KermanX
Loading

This PR adds Chinese character set for word counting and modify wordCount function

close #1845

@HoshinoSuzumi
fix: word count errors in client (slidevjs#1845)
e451480 
Add Chinese character set for word count
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for slidev ready!

Name Link
🔨 Latest commit bb48262
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/66d56202f074da000855c70a
😎 Deploy Preview https://deploy-preview-1846--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HoshinoSuzumi HoshinoSuzumi changed the title fix: word count errors in client (#1845) fix: Chinese character counting error in overview page (#1845) Aug 28, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 30, 2024 •
edited
Loading

Open in Stackblitz

create-slidev

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev@1846

@slidev/client

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/client@1846

@slidev/parser

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1846

create-slidev-theme

pnpm add https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1846

@slidev/cli

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1846

@slidev/types

pnpm add https://pkg.pr.new/slidevjs/slidev/@slidev/types@1846

commit: bb48262

KermanX
KermanX approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@KermanX KermanX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

The current implementation is neat. It would be better if we can find a tiny and stable library to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@KermanX KermanX KermanX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The word count does not contain Chinese characters
3 participants
@HoshinoSuzumi @antfu @KermanX