Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Migrate CodeMirror to Monaco #1391

Closed
antfu opened this issue Mar 8, 2024 · 0 comments · Fixed by #1698
Closed

RFC: Migrate CodeMirror to Monaco #1391

antfu opened this issue Mar 8, 2024 · 0 comments · Fixed by #1698
Labels
enhancement New feature or request rfc

Comments

@antfu
Copy link
Member

antfu commented Mar 8, 2024

Currently, we use CoreMirror for the in-app editor, while we support Monaco in the sides. With #1330 solving the major problem we had in Monaco, it makes it less optimal to maintain two different text editors. Now, with the Shiki Monaco integration, we could have a much better syntax highlight for the markdown content as well.

Consider the in-app editor only has a single instance and it's dev only, performance shouldn't a major concern.

This is also related to #1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rfc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant