Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config and storage path handling #8

Open
slice opened this issue Dec 17, 2019 · 1 comment
Open

Improve config and storage path handling #8

slice opened this issue Dec 17, 2019 · 1 comment
Labels

Comments

@slice
Copy link
Owner

slice commented Dec 17, 2019

Default JSON storage files (such as insects.json) exist relative to the current working directory. However, should they exist relative to the source code? How can this be specified? Right now, they clog up the current working directory, introducing the possibility of them being accidentally git added into version control.

This issue can also apply to the config folder. Where should that go? Relative to the source code, or somewhere else?

We might have to introduce another conflict (data dir? config dir?) in order to solve this.

@slice slice added the P-medium label Dec 17, 2019
@lun-4
Copy link
Collaborator

lun-4 commented Dec 20, 2019

short term solution: python -m lifesaver.init, add config.yml, add .gitignore

long term solution: data dirs, with the id of the data dir for a specific bot being based off pipenv's id's for virtualenvs (project + hash of path to project)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants