Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill 2.0.x | Slab | Using 3-set Korean IME during collaborative editing caused incorrect content synchronization. #4449

Open
weiQuill opened this issue Oct 14, 2024 · 2 comments

Comments

@weiQuill
Copy link

weiQuill commented Oct 14, 2024

Please describe the a concise description and fill out the details below. It will help others efficiently understand your request and get to an answer instead of repeated back and forth. Providing a minimal, complete and verifiable example will further increase your chances that someone can help.

Steps for Reproduction

  1. Open the same doc in Slab with 2 windows.
  2. Create some empty lines.
  3. Change to 3-Set Korean IME.
  4. Focus into one of the editor.
  5. Hold t key to type in the editor.
  6. Click into another window to keep typing in the editor.(Don't release t)
  7. You will see the issue, the contents of the two editors are inconsistent.
Screen.Recording.2024-10-14.at.15.10.26.mov

Expected behavior:
The contents of the two editors are consistent.

Actual behavior:
The contents of the two editors are inconsistent.

Platforms:
macOS 14.7 & Chrome Version 129.0.6668.101
Include browser, operating system and respective versions

Version:
Quill 2.0.x

@weiQuill
Copy link
Author

I tried the steps in YJS demo, it only happens in quill 2.0.x, works fine in 1.3.7.
I suspect it's caused by batchStart and batchEnd in the composition events handlers, removing them will fix the main issue, but will bring Japanese Hiragana Windows IME ignores first letter in editor #1453
back.

Any suggestions? I found that batchStart and batchEnd were not added to the composition events handlers in 1.3.7, and there is also no first letter issue. How did we fix this problem for 1.3.7?
Thanks a lot:)

@vincentdchan
Copy link

vincentdchan commented Oct 15, 2024

We can solve the “first-letter issue” in this PR: slab/parchment#151
And solve the editing issue by disable batchStart and batchEnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants