Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document error in week2 day5 #98

Open
CNYuYang opened this issue Oct 9, 2024 · 2 comments
Open

document error in week2 day5 #98

CNYuYang opened this issue Oct 9, 2024 · 2 comments

Comments

@CNYuYang
Copy link

CNYuYang commented Oct 9, 2024

document:

The manifest format is like:

| JSON record | JSON record | JSON record | JSON record |

Again, note that we do not record the information of how many bytes each record has.

but mini-lsm/manifest.rs

// record how many bytes each record has
file.write_all(&(buf.len() as u64).to_be_bytes())?;

so,The real format is:

| len,JSON record,crc | len,JSON record,crc | len,JSON record,crc | len,JSON record,crc |
@CNYuYang
Copy link
Author

CNYuYang commented Oct 9, 2024

echo JSON objects must be separated by certain means.

@CNYuYang
Copy link
Author

CNYuYang commented Oct 9, 2024

No problem. I made a mistake.

@CNYuYang CNYuYang closed this as completed Oct 9, 2024
@skyzh skyzh reopened this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants