Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database indexes #59

Open
ronaldbarendse opened this issue Nov 12, 2019 · 2 comments
Open

Add database indexes #59

ronaldbarendse opened this issue Nov 12, 2019 · 2 comments
Labels
status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future umbraco/v8 Issues and tasks related to Umbraco 8.

Comments

@ronaldbarendse
Copy link

The SkybrudRedirects table should get some database indexes, as retrieving rows currently scans the whole table and that can take quite some time, especially when a lot of redirects are added...

The built-in Umbraco umbracoRedirectsUrl table indexes a hash of the URL, together with the resulting content/node key, culture and creation date. This ensures the index isn't unneccesary large and sorting on most recently added redirect can also be done efficiently within the database.

@abjerner abjerner added the umbraco/v8 Issues and tasks related to Umbraco 8. label Nov 28, 2019
@abjerner
Copy link
Member

@ronaldbarendse thanks for creating this issue. It may not make as much sense if a cache layer is introduced, but I'll keep it in mind 👍

@ronaldbarendse
Copy link
Author

Caching won't make it faster, as it still needs to get the data from the database. Loading all redirects into the cache also isn't efficient (especially with large amounts of redirects) and an anti-pattern, as you should only cache frequently used objects.

@abjerner abjerner added the status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future umbraco/v8 Issues and tasks related to Umbraco 8.
Projects
None yet
Development

No branches or pull requests

2 participants