Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration-test in pull request checks #417

Open
aidandunlop opened this issue Dec 18, 2024 · 1 comment · May be fixed by #420
Open

Run integration-test in pull request checks #417

aidandunlop opened this issue Dec 18, 2024 · 1 comment · May be fixed by #420

Comments

@aidandunlop
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current PR checks (make prBuild) do not include the integration-test makefile rule, meaning integration tests do not run on each PR. This has recently meant broken code was checked into the default branch.

Describe the solution you'd like
Run the integration tests in the PR checks.

Describe alternatives you've considered
n/a

Additional context

  • Need to ensure that integration-test-up and integration-test-down are run as appropriate
@aidandunlop aidandunlop linked a pull request Dec 19, 2024 that will close this issue
Draft
@TobyPinfold
Copy link
Contributor

This was picked up as a quick win, its however proved to be more involved than expected and requires more dedicated time to investigate issues with the CI tooling for prBuild checks. The issues revolves around minikube usage and the readiness state of the workflow-manager never entering a Running state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make integration tests run in pr checks sky-uk/kfp-operator
2 participants
@TobyPinfold @aidandunlop