Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deps to peer deps #27

Open
iamolegga opened this issue Oct 31, 2019 · 2 comments
Open

Move deps to peer deps #27

iamolegga opened this issue Oct 31, 2019 · 2 comments

Comments

@iamolegga
Copy link
Contributor

Hi, thanks for package!

I see, that there are packages, that could be moved to peer dependencies, because every nest app already use it:

"@nestjs/common": "6.3.1",
"reflect-metadata": "^0.1.12",
"rxjs": "^6.2.2",

Would you mind if I'll create PR to fix this?
@iamolegga
Copy link
Contributor Author

Also if you want I can help with configuring ci/cd for testing and package deploying

@skunight
Copy link
Owner

OK，thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skunight @iamolegga