match_score and matching_score in fuzzy_join are confusing
#803
Closed
jeromedockes
started this conversation in
General
Replies: 3 comments 1 reply
-
|
Agreed with the confusing, but the replacements proposal are too long.
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
maybe |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Yes, that great! |
Beta Was this translation helpful? Give feedback.
-
|
has been fixed in #821 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
in
fuzzy_join,matching_scorerefers to the score obtained by each row (eg amatching_scorecolumn is added whenreturn_score=True) andmatch_scoreis the minimum matching score for a match to be accepted. The 2 names are very similar and it is not clear how the terms' meaning differ making it hard to remember which is which. maybe better names would bematch_scoreandmin_match_score,match_score_thresholdor something similarBeta Was this translation helpful? Give feedback.
All reactions