Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with direct lookup of a concept #280

Closed
acka47 opened this issue Nov 14, 2023 · 10 comments
Closed

Problem with direct lookup of a concept #280

acka47 opened this issue Nov 14, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@acka47
Copy link
Member

acka47 commented Nov 14, 2023

The concept at question is https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N448000

When I click through the hierarchy and go to this concept, everything is fine. Doing a direct lookup of the URL I get this:

image

This might well be an error in the concept scheme. However, if it breaks the application we should exclude such errors in the validation process.

@acka47
Copy link
Member Author

acka47 commented Nov 14, 2023

This might well be an error in the concept scheme.

Hmm, it doesn't look wrong to me: https://github.com/hbz/lobid-vocabs/blob/57ae3ed05324d57452fc2a3a7bee04adb3ca23e3/nwbib/nwbib.ttl#L2690-L2698

@sroertgen
Copy link
Contributor

This is related to PR #279
The test system is already serving the current dev version without the language tags

@sroertgen
Copy link
Contributor

@acka47 if you visit it the second time, does it work?

@sroertgen
Copy link
Contributor

Will look into it. Maybe I have overlooked something regarding hash uris

@sroertgen sroertgen self-assigned this Nov 14, 2023
@sroertgen sroertgen added the bug Something isn't working label Nov 14, 2023
@acka47
Copy link
Member Author

acka47 commented Nov 14, 2023

Investigating this further, there are neither skos:definition nor skos:scopeNote shown although they are in the SKOS file, see https://github.com/hbz/lobid-vocabs/blob/57ae3ed05324d57452fc2a3a7bee04adb3ca23e3/nwbib/nwbib.ttl#L2690-L2698

Instead it reads:

No scope note in language "undefined" provided.

This applies to all other concepts withscopeNote or definition, see e.g. https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N124000 or https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N865020

Apparently, this is a problem with #279, so this should be considered as part of the review of #279.

@acka47 acka47 mentioned this issue Nov 14, 2023
2 tasks
@acka47
Copy link
Member Author

acka47 commented Nov 14, 2023

if you visit it the second time, does it work?

Yes, in the sense that there is no error message, no in the sense that definition and scopeNote are not shown.

@sroertgen
Copy link
Contributor

@acka47
title, definition, scope note etc should now be working again after a rebuilt of the vocabs.
What I still have to investigate:
If a hashURI concept is visited directly you first see the concept scheme and need to reload to see the concept, e.g. https://test.skohub.io/sroertgen/test-vocabs/heads/main/nwbib.de/subjects.html#N841000

@sroertgen
Copy link
Contributor

The before mentioned problem should now also be fixed. If you rebuild, the vocab should behave like expected again

@sroertgen
Copy link
Contributor

@acka47 Is this still an issue?
Direct lookup of concepts seem to be working.

@sroertgen sroertgen added this to SkoHub Mar 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in SkoHub Mar 22, 2024
@acka47
Copy link
Member Author

acka47 commented Mar 22, 2024

I think this was fixed some time ago and works now like a charme: https://skohub.io/hbz/lobid-vocabs/heads/testingSkoHub/nwbib.de/subjects.html#N448000

Closing.

@acka47 acka47 closed this as completed Mar 22, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in SkoHub Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants