From 4464b7c85db27fb7043ca446c2e69b51db1d8c97 Mon Sep 17 00:00:00 2001 From: freeelancer Date: Mon, 23 Sep 2024 19:11:08 +0800 Subject: [PATCH 1/2] fix nil pointer for gas_prices query --- x/feemarket/keeper/feemarket.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/x/feemarket/keeper/feemarket.go b/x/feemarket/keeper/feemarket.go index 103e614..84c8e04 100644 --- a/x/feemarket/keeper/feemarket.go +++ b/x/feemarket/keeper/feemarket.go @@ -114,6 +114,10 @@ func (k *Keeper) GetMinGasPrices(ctx sdk.Context) (sdk.DecCoins, error) { minGasPrice := sdk.NewDecCoinFromDec(params.FeeDenom, baseGasPrice) minGasPrices := sdk.NewDecCoins(minGasPrice) + if k.resolver == nil { + return minGasPrices, nil + } + extraDenoms, err := k.resolver.ExtraDenoms(ctx) if err != nil { return sdk.NewDecCoins(), err From f76308a21b037f29161ba20db3aac2fdc29f6c74 Mon Sep 17 00:00:00 2001 From: freeelancer Date: Tue, 24 Sep 2024 13:23:30 +0800 Subject: [PATCH 2/2] added test for gas_prices --- x/feemarket/keeper/query_server_test.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/x/feemarket/keeper/query_server_test.go b/x/feemarket/keeper/query_server_test.go index e6dfb9e..83e5705 100644 --- a/x/feemarket/keeper/query_server_test.go +++ b/x/feemarket/keeper/query_server_test.go @@ -156,4 +156,19 @@ func (s *KeeperTestSuite) TestBaseFeeRequest() { s.Require().Equal(resp.GetPrice(), fee) }) + + s.Run("can get gas prices", func() { + // set denom resolver to nil assuming that it is not set + s.feeMarketKeeper.SetDenomResolver(nil) + + req := &types.GasPricesRequest{} + resp, err := s.queryServer.GasPrices(s.ctx, req) + s.Require().NoError(err) + s.Require().NotNil(resp) + + gasPrices, err := s.feeMarketKeeper.GetMinGasPrices(s.ctx) + s.Require().NoError(err) + + s.Require().Equal(resp.GetPrices(), gasPrices) + }) }