Merge pull request #284 from sshehata/master

Sentimentron · web-flow · commit 74ae077eafb2 · 2022-12-28T16:30:02.000Z
feat: allow missing values when parsing csvs
diff --git a/base/csv.go b/base/csv.go
@@ -187,6 +187,11 @@ func ParseCSVBuildInstancesFromReader(r io.ReadSeeker, attrs []Attribute, hasHea
 			}
 		}
 		for i, v := range record {
+			// support missing values
+			if v == "" {
+				continue
+			}
+
 			u.Set(specs[i], rowCounter, specs[i].attr.GetSysValFromString(strings.TrimSpace(v)))
 		}
 		rowCounter++

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,11 @@ func ParseCSVBuildInstancesFromReader(r io.ReadSeeker, attrs []Attribute, hasHea`
`187`	`187`	`}`
`188`	`188`	`}`
`189`	`189`	`for i, v := range record {`
	`190`	`+ // support missing values`
	`191`	`+ if v == "" {`
	`192`	`+ continue`
	`193`	`+ }`
	`194`	`+`
`190`	`195`	`u.Set(specs[i], rowCounter, specs[i].attr.GetSysValFromString(strings.TrimSpace(v)))`
`191`	`196`	`}`
`192`	`197`	`rowCounter++`