Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide tooltip (menu items) when opening dropdowns (e.g. font-size / paragraph) #308

Closed
alaa-paramount opened this issue Dec 22, 2024 · 3 comments · Fixed by #310
Closed

Hide tooltip (menu items) when opening dropdowns (e.g. font-size / paragraph) #308

alaa-paramount opened this issue Dec 22, 2024 · 3 comments · Fixed by #310

Comments

@alaa-paramount
Copy link

Describe the bug

The tooltip menu items are currently displayed above all the drop-down selection menus which is disturbing for the user (sometimes it can block the selections from dropdown)

To Reproduce

Steps to reproduce the behavior:

  1. Hover over font-size menu (you will see tooltip of "Font size" by default)
  2. When clicking and opening the dropdown of "font-size", you will keep seeing the tooltip of "Font size" above all the dropdown menu
  3. The tooltip sometimes can block your dropdown selection (depends on dropdown position)

Expected behavior

Menu tooltips should be hidden when user opening any drop-downs
@sjdemartini
Copy link
Owner

This is similar to #282 and #283, though slightly different/narrower issue and recommended solution. I do like the idea of closing the tooltip if you've opened select options, so I'll open a PR for that 😄

sjdemartini added a commit that referenced this issue Dec 22, 2024
@sjdemartini
Close MenuSelect tooltip if opening dropdown options
ece6faf 
This ensures menu items aren't blocked, etc., and the tooltip need not
continue to be displayed if you've already clicked the select.

Resolves #308
sjdemartini added a commit that referenced this issue Dec 22, 2024
@sjdemartini
Close MenuSelect tooltip if opening dropdown options
135c7d0 
This ensures menu items aren't blocked, etc., and the tooltip need not
continue to be displayed if you've already clicked the select.

Resolves #308
@sjdemartini sjdemartini mentioned this issue Dec 22, 2024
Merged
sjdemartini added a commit that referenced this issue Dec 22, 2024
@sjdemartini
Close MenuSelect tooltip if opening dropdown options
b374150 
This ensures menu items aren't blocked, etc., and the tooltip need not
continue to be displayed if you've already clicked the select.

Resolves #308
@sjdemartini
Copy link
Owner

This is now released in https://github.com/sjdemartini/mui-tiptap/releases/tag/v1.15.1

@alaa-paramount
Copy link
Author

@sjdemartini Works, thanks alot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close MenuSelect tooltip when opening dropdown options sjdemartini/mui-tiptap
2 participants
@sjdemartini @alaa-paramount