-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a branch breaks, a tree falls down #56
Comments
Fixed on commit 0333c21 Now, when one or more layers of the tree are not accessible for any reason, the app no longer displays any type of error message; it simply removes those layers from the tree and proceeds to load the viewer. |
@RicardCots @mvinent @silmeUsil0001 please review this solution. IMHO, quiet removal of layers is a bad idea. It make impossible to users to realize a bad configuration and notify to SITMUN administrators of the issue. Layers may be removed, but not silently as the commit implies! |
I thought that no type of error should appear. If you want, I can add back the little toast message that appeared when loading an application in case a layer couldn't be loaded. |
Note that several layers may have problems (not only one). Also, I recommend to report it in the console log. |
In SITMUN 2 we often use the same tree for different users, and each user only gets the layers he has access to. So in my opinion the user should not receive any error or information message. On the other hand, it would be interesting for the SITMUN system administrator to know which layers are in the tree but are not loaded, but not for the user. Maybe it would be enough reporting it in de console log. |
Commit 5c6c82b add console log type messages when one or more layers cannot be accessed, instead of showing the old toast type error messages. |
Describe the bug
When the SITMUN viewer tries to load a tree containing one or more layers for which that user or territory does not have permission, and which are part of a node where no other layer has permission, the tree is not loaded in the viewer.
In other words, if the tree you are trying to open contains any node with layers without permissions for this user, the tree will not be loaded.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Se espera el mismo comportamiento que en SITMUN 2. Si en un arbol hay una o varias capas definidas para las que un usuario no dispone de permisos de acceso, se cargan todas las capas excepto esas. Independientemente de si hay un o varias capas sin permisos.
Screenshots
![image](https://private-user-images.githubusercontent.com/48914626/369416584-33ff25ea-4509-4cc2-b582-8cfd81654ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjA3MjQsIm5iZiI6MTczOTY2MDQyNCwicGF0aCI6Ii80ODkxNDYyNi8zNjk0MTY1ODQtMzNmZjI1ZWEtNDUwOS00Y2MyLWI1ODItOGNmZDgxNjU0ZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMDAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJiODcwMTRmMzNiOWUxNzMzNjk5YzYyNWU1NmZmMTIyZDc2NTU3ZTk5ODhjZDU4ZDRmYjE1NWViNTRkZTdiMjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FQsQTNgNF7Gd7vwjcqISzQWOGEsNi3ckwOpIoDjndoo)
First add a folder and a layer in the tree. Be sure the layer has not permissions for the user / aplication 7 territory.
See the error
![image](https://private-user-images.githubusercontent.com/48914626/369416698-13124e5c-3906-4a08-9bb8-6353a2e974eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjA3MjQsIm5iZiI6MTczOTY2MDQyNCwicGF0aCI6Ii80ODkxNDYyNi8zNjk0MTY2OTgtMTMxMjRlNWMtMzkwNi00YTA4LTliYjgtNjM1M2EyZTk3NGViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIzMDAyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE4NzU3NTAwYTc0NWY4ZjdkNzRiZTFkOWEzMDA3MGUxMmE0ZTk1OTY3MmM5M2ZiMTVlZjQzZjQ5NzU5ZWI2OWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WRHOnpsBDelHxL3M72fsd_BGSk5qN26XH9iIQy93Pks)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: