Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TRPO/PPO to new package: PolicyOptimization.jl #1

Open
2 tasks
mossr opened this issue Sep 5, 2020 · 3 comments
Open
2 tasks

Move TRPO/PPO to new package: PolicyOptimization.jl #1

mossr opened this issue Sep 5, 2020 · 3 comments

Comments

@mossr
Copy link
Member

mossr commented Sep 5, 2020

The TRPO and PPO implementations are general enough to be in their own solver package in the POMDPs.jl ecosystem. I've already encapsulated these solvers into the DeepRL module.

Some TODOs:

  • Extract AST specific code and generalize TRPO and PPO solvers
  • Test on different POMDPs.jl example

Among other things to be appended to this list.
mossr added a commit that referenced this issue Sep 5, 2020
@mossr
Moved DRL code to the DeepRL.jl module #1
ed0cc62
@MaximeBouton
Copy link
Member

Maybe they could be a TRPO.jl and PPO.jl ? or PolicyOptimization.jl with both?

@mossr
Copy link
Member Author

mossr commented Sep 5, 2020

Agreed. They share a lot of base code, so I like PolicyOptimization.jl over DeepRL.jl.

@MaximeBouton
Copy link
Member

cool, then that is kind of consistent with DeepQLearning.jl
RLInterface will need to be registered to general before you register PolicyOptimization.jl btw

@mossr mossr changed the title Move DeepRL.jl module to separate package Move TRPO/PPO to new package: PolicyOptimization.jl Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mossr @MaximeBouton