Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return last resolved model if {conditional: true} #30

Open
ralphsmith80 opened this issue Mar 6, 2014 · 0 comments
Open

return last resolved model if {conditional: true} #30

ralphsmith80 opened this issue Mar 6, 2014 · 0 comments

Comments

@ralphsmith80
Copy link
Member

It looks like this commit left out the return statement here. Since we're close to a release I'm not fixing this yet. Additionally this is a performance measure to not send a request when it is unneeded. Here are some things to consider when we do fix this;

  • what if we include params with the conditional that would require a reload. For example.
model.refresh({include: ['accesslist']}, {conditional: true})

put on the breaks

We're not going to get crazy with this stuff trying to resolve special case logic here. If a special call is made with params the require a reload then just don't include the conditional option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant