-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential bug #170
Comments
Same assumption goes for: Line 42 in 1b2a808
|
These standards do not mandate port ranges or string lengths for the https://tools.ietf.org/html/rfc2327#page-19 Also, the assumption is that the media type is
I have seen making:
|
But this is not a safe assumption. a media type of |
Yeah could be improved. |
heplify/decoder/correlator.go
Line 53 in 1b2a808
Potentially, this is wrong. This assumes that only non-privileged ports are used by the declaring host. If the host declaring the SDP has port number 8 available to listen, the string is shorter. I have seen these in the wild.
Consider
i.e.
I think.
The text was updated successfully, but these errors were encountered: