Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraArgs? #4

Closed
benley opened this issue Oct 25, 2024 · 4 comments
Closed

Remove extraArgs? #4

benley opened this issue Oct 25, 2024 · 4 comments

Comments

@benley
Copy link
Collaborator

benley commented Oct 25, 2024

Is there actually a use case for extraArgs? Anything you could do with that could also be done with a single invocation of tailscale set, so what is the point of having it in tailscale-manager?

@benley
Copy link
Collaborator Author

benley commented Dec 3, 2024

I'm not sure what happened to it but someone commented with this a few weeks ago:

It's useful in some cases. For example, we run Tailscale in a container, and the tailscaled socket is stored in /tmp/tailscaled.sock, so we need to append --socket="/tmp/tailscaled.sock to tailscale set commands for them to work properly

@benley benley closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
@SamyDjemai
Copy link
Contributor

Yep that was me! I removed my comment because the socket arg has to be defined outside of the extraArgs, see #10

@benley
Copy link
Collaborator Author

benley commented Dec 3, 2024

Oh, I see that now! I'm just starting to catch up after a few weeks away. What do you think, is extraArgs something we should keep around as an escape hatch?

@SamyDjemai
Copy link
Contributor

I don't see any use for it right now, but I don't feel like it's enough to delete it 😅 I'd keep it around IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants