-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Grammar to SinglestoreGrammar #95
Comments
It sounds like a nice idea.
All these classes can be prefixed with |
Ok. Sounds good. What should timing be? Or next steps? I'm happy to PR these changes, but not sure if this alone is worth moving to v2 unless you already have plans for a v2 that this can just be part of? |
Currently, no new features are planned for the connector, and I’m not sure when there will be. So I’m okay with bumping the version to v2 just for this change. Feel free to submit a PR, and we can move forward with it. |
I'm not sure if this would be a breaking change for some, so I want to discuss before sending in a PR.
I'm having to build a unique grammar for a binary column and realized that the Grammar class doesn't uniquely identify itself like the other drivers in the ecosystem for laravel. For example,
MySqlGrammar
,PostgresGrammar
, etc.If we make this change, than anyone using the
Grammar
class to override or add macros would cause breaking changes. I think this is better for the long term and want to put it on the radar.Thoughts? I'm happy to make a PR if this is the direction you want to go.
The text was updated successfully, but these errors were encountered: