Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not load localizations for Link edit dialog #1534

Closed
1 task done
bambinoua opened this issue Nov 15, 2023 · 7 comments
Closed
1 task done

Could not load localizations for Link edit dialog #1534

bambinoua opened this issue Nov 15, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@bambinoua
Copy link
Contributor

Is there an existing issue for this?

Steps to reproduce

  1. Select a portion of text.
  2. Press on Link button to create an HTML link
  3. Get a crash The instance of FlutterQuillLocalizations.of(context) is null and it is required...

Expected results

Link dialog open is expected

Actual results

Red flutter scree

Code sample

MaterialApp(
  localizationDelegates: [
    GlobalMaterialLocalizations.delegate,
    FlutterQuillLocalizations.delegate,    // it is specified!
  ],
),

Screenshots or Video

No response

Logs

No response

Flutter Doctor output (optional)

No response

@bambinoua bambinoua added the bug Something isn't working label Nov 15, 2023
@EchoEllet
Copy link
Collaborator

Is there an existing issue for this?

Steps to reproduce

  1. Select a portion of text.
  2. Press on Link button to create an HTML link
  3. Get a crash The instance of FlutterQuillLocalizations.of(context) is null and it is required...

Expected results

Link dialog open is expected

Actual results

Red flutter scree

Code sample

MaterialApp(
  localizationDelegates: [
    GlobalMaterialLocalizations.delegate,
    FlutterQuillLocalizations.delegate,    // it is specified!
  ],
),

Screenshots or Video

No response

Logs

No response

Flutter Doctor output (optional)

No response

Thank you for the report, we will check it out soon

@EchoEllet
Copy link
Collaborator

I'm unable to get the bug you are facing

image

Can you update the sample code?

@EchoEllet
Copy link
Collaborator

FlutterQuillLocalizations

Are you running the example code?? if not then are you using a custom toolbar??

@EchoEllet
Copy link
Collaborator

EchoEllet commented Nov 15, 2023

I'm only able to encounter the a different issue when removing the

FlutterQuillLocalizations.delegate

@EchoEllet
Copy link
Collaborator

EchoEllet commented Nov 15, 2023

The issue that I'm encountering is now fixed in 8.5.5 where it only happens when you don't add

FlutterQuillLocalizations.delegate

to your MaterialApp

@bambinoua
Copy link
Contributor Author

bambinoua commented Nov 16, 2023

@freshtechtips I could not test the version 8.5.6 because of #1537

@bambinoua
Copy link
Contributor Author

Ok. I tested on forked and reverted branch. Looks working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants