Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor is not read only when i select text and press ctrl+i or ctrl+b #1533

Closed
1 task done
Nightwelf opened this issue Nov 15, 2023 · 4 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@Nightwelf
Copy link

Is there an existing issue for this?

Steps to reproduce

after upgrade from 8.2.6 to latest read only broken :(
please fix it

Expected results

editor is read only

Actual results

editor is not read only

Code sample

Code sample
QuillEditor(
                            focusNode: widget.controller.focus,
                            scrollController: widget.controller.scroll,
                            configurations: QuillEditorConfigurations(
                              editorKey: widget.controller.key,
                              customStyles: getQuillDefaultStyles(context),
                              onLaunchUrl: (url) {
                                context.navigateAnywhere(url);
                              },
                              readOnly: true,
                              showCursor: false,
                              enableSelectionToolbar: false,
                              scrollable: true,
                              autoFocus: false,
                              placeholder: placeholder,
                              embedBuilders: getQuillEmbedBuilders,
                              maxHeight: maxHeight,
                              minHeight: widget.controller.minHeight
                            ),
                          );

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output (optional)

Doctor output
[Paste your output here]
@Nightwelf Nightwelf added the bug Something isn't working label Nov 15, 2023
@singerdmx
Copy link
Owner

Hello there, on behalf the Flutter Quill Team I would like to thank you for opening your first issue. Your inputs and insights are valuable in shaping a stable and reliable version for all our users. Thank you for being part of the open-source community!

@Nightwelf Nightwelf changed the title after upgrade from 8.2.6 to latest read only broken editor is not read only when i select text and press ctrl+i or ctrl+b Nov 15, 2023
@EchoEllet
Copy link
Collaborator

EchoEllet commented Nov 15, 2023

Is there an existing issue for this?

Steps to reproduce

after upgrade from 8.2.6 to latest read only broken :( please fix it

Expected results

editor is read only

Actual results

editor is not read only

Code sample

Code sample

QuillEditor(
                            focusNode: widget.controller.focus,
                            scrollController: widget.controller.scroll,
                            configurations: QuillEditorConfigurations(
                              editorKey: widget.controller.key,
                              customStyles: getQuillDefaultStyles(context),
                              onLaunchUrl: (url) {
                                context.navigateAnywhere(url);
                              },
                              readOnly: true,
                              showCursor: false,
                              enableSelectionToolbar: false,
                              scrollable: true,
                              autoFocus: false,
                              placeholder: placeholder,
                              embedBuilders: getQuillEmbedBuilders,
                              maxHeight: maxHeight,
                              minHeight: widget.controller.minHeight
                            ),
                          );

Screenshots or Video

Screenshots / Video demonstration

Logs

Logs

Flutter Doctor output (optional)

Doctor output

Hi, thank you for the report.

Can you explain in a little more detail where are you testing?? is it in the example?? because the readOnly function is working I just tested it, can you give me more details about the issue, maybe how to get the issue, what are you trying to do and what is the result and expected, a few screenshots could help

What is the platform you using for testing?

@AtlasAutocode
Copy link
Collaborator

The current version does not have this problem.
If the problem still exists, please reopen and let us know how to reproduce the program.

@EchoEllet
Copy link
Collaborator

EchoEllet commented Sep 21, 2024

@AtlasAutocode @CatHood0 Not related to this issue but just to be extra sure, we probably don't want to close issues if the only reason is that they are outdated and open for a while without any response especially if they are bug reports. There are issues from 2020 or 2021 that are still applicable but we have closed many of them (which has not been made recently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants