Discussion: Delta model

[ericmartineau]

I'm trying to create some custom embeds and running into issues...

In the current flutter-quill examples, all embeds get resolved down to a string, like a URL... but my embeds have multiple properties for each instance. There are a few places in the framework where there's a hard-cast on the embed data to be a String. This one is particularly odd, since the method declares Map<String, dynamic>, but then there's a hard cast to Map<String, String> in the method body.

class Embeddable {
  Map<String, dynamic> toJson() {
      final m = <String, dynamic>{type: data};
      return m;
  }
}

Secondly, I started bumping up against the Compose Failed error from document.dart:170

    if (_delta != _root.toDelta()) {
      throw 'Compose failed';
    }

This is happening because the _root.toDelta() appears to be converting Embeddable instances into a Map<String, dynamic> where as _delta contains Embeddable instances. But I can't pass a Map<String, dynamic> as the data when calling document.replaceText (it requires either a String or Map<String, dynamic>).

Overall (and this may be a personal preference)... I would like to see more type-hints when working with quill model in real-time, with a separate serialization/deserialization routine that only happens on the boundaries (when data is imported or exported).

But, I may be missing something. Thoughts?

[EgorK0rshun]

have the same exception with default realisation
UnhandledFlutterException: Compose failed at flutter_quill.src.models.documents.document.dart.Document.compose(document.dart:274) at flutter_quill.src.models.documents.document.dart.Document.delete(document.dart:96) at flutter_quill.src.models.documents.document.dart.Document.replace(document.dart:124) at flutter_quill.src.widgets.controller.dart.QuillController.replaceText(controller.dart:194) at flutter_quill.src.widgets.raw_editor.raw_editor_state_selection_delegate_mixin.dart.RawEditorStateSelectionDelegateMixin.textEditingValue=(raw_editor_state_selection_delegate_mixin.dart:31) at flutter_quill.src.widgets.raw_editor.raw_editor_state_selection_delegate_mixin.dart.RawEditorStateSelectionDelegateMixin.userUpdateTextEditingValue(raw_editor_state_selection_delegate_mixin.dart:149) at flutter_quill.src.widgets.raw_editor.dart.RawEditorState._replaceText(raw_editor.dart:1255)

[EgorK0rshun]

maybe someone know, how to fix this? There is more then 10k events with this issue