diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6c5fdd08..f7656b56 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,10 +4,10 @@ If you're adding support for a new file type, please follow the below steps: - Add a fixture file named `fixture.` to the `fixture` directory. - Add the file extension to the `extensions` array in `supported.js`. - Add the file's MIME type to the `types` array in `supported.js`. -- Add the file type detection logic to the `core.js` file +- Add the file type detection logic to the `core.js` file. - Determine the appropriate detection confidence category: - - `detectConfident()`: Detections with a high degree of certainty in identifying the correct file type - - `detectImprecise()`: Detections with limited supporting data, resulting in a higher likelihood of false positives + - `detectConfident()`: Detections with a high degree of certainty in identifying the correct file type. + - `detectImprecise()`: Detections with limited supporting data, resulting in a higher likelihood of false positives. - Respect the sequence: - Signature with shorter sample size (counted from offset 0 until the last required byte position) will be executed first. - Only the initial determination for the file type counts for the sequence.