Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare optional arguments on ABCDatabase.*_access methods #613

Open
flongford opened this issue Jun 29, 2022 · 0 comments
Open

Declare optional arguments on ABCDatabase.*_access methods #613

flongford opened this issue Jun 29, 2022 · 0 comments
Labels

Comments

@flongford
Copy link
Contributor

flongford commented Jun 29, 2022

Not all of the The ABCDatabase.grant_access and ABCDatabase.revoke_access method arguments appear to be required.

def grant_access(self, app_name, user_name, app_license,
allow_home, allow_view, volume, allow_startup_data):

def revoke_access(self, app_name, user_name, app_license,
allow_home, allow_view, volume, allow_startup_data):

In fact all of them except app_name and user_name could probably be made optional with given defaults, since our implementations already expect to handle falsy values anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant