Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source parser/reader #620

Open
yoavnash opened this issue Apr 28, 2021 · 9 comments
Open

Data source parser/reader #620

yoavnash opened this issue Apr 28, 2021 · 9 comments
Labels
👩‍🎓 newcomer task Issue that is a good entry point to the source code for a newcomer. 🌱 new feature Solving the issue involves the incorporation of a new feature. ⚡ breaking change Solution introduces incompatible API changes, MAJOR version number update. See https://semver.org.

Comments

@yoavnash
Copy link
Member

yoavnash commented Apr 28, 2021 •
edited
Loading

So far we had wrappers for simulations and for data sink (to store data). We still don't have a wrapper for extracting data from an existing data repo. Such a wrapper would be beneficial for demos and various applications.

Suggestions:

  • NOMAD Wrapper
  • OPTIMADE wrapper
  • Standard data formats. For example, STL for geomatrical representation.

Could be related to #267 and #290
@yoavnash yoavnash added ⚙️ wrappers Issues related to wrappers and/or wrapper development and the Wrapper API. 👩‍🎓 newcomer task Issue that is a good entry point to the source code for a newcomer. labels Apr 28, 2021
@pablo-de-andres
Copy link
Member

Do we just want to extract data? Because then I would not use a wrapper, since both simulations and data storage can be used for communication in both directions which I think is part of what makes wrappers wrappers

@yoavnash
Copy link
Member Author

Good point. It can still be beneficial though to have a "read-only" wrapper, for direct access to data in an OSP-core script.

@pablo-de-andres
Copy link
Member

I think would define another component at the same level as wrappers. A parser/reader, if you will.
And we could divide between data repos, excel files and other formats...

@yoavnash
Copy link
Member Author

That sounds indeed better. Great suggestion.

@yoavnash yoavnash changed the title Data source wrapper Data source parser/reader Apr 28, 2021
@yoavnash yoavnash added feature request 💡 and removed ⚙️ wrappers Issues related to wrappers and/or wrapper development and the Wrapper API. labels Apr 28, 2021
@pablo-de-andres
Copy link
Member

It might make for a nice symmetric design if we think of readers, writers and wrappers

@yoavnash yoavnash mentioned this issue May 18, 2021
Closed
@MBueschelberger
Copy link
Member

It might make for a nice symmetric design if we think of readers, writers and wrappers

Definitely agree.

In case of the GMSHWrapper, I followed a separation between engine, (which takes the role of a reader and writer) and the actual wrapper by two different classes.

According to my experience with this module from the FORCE-project, if there is a syntactic third-party-tool already available, the reader and writer part might be quite easy. The semantic interpretation through a wrapper and the related ontology is much more timeconsuming, as we all now...

@yoavnash
Copy link
Member Author

Could be related to mapping data from tables to RDF. Related technologies:

@kysrpex kysrpex added the ⚡ breaking change Solution introduces incompatible API changes, MAJOR version number update. See https://semver.org. label Jun 9, 2021
@kysrpex
Copy link
Contributor

kysrpex commented Jun 9, 2021

I am labelling this also as breaking change as we might want to introduce a new API or do changes to the wrapper API for this.

@kysrpex
Copy link
Contributor

kysrpex commented Jun 9, 2021

Related #651.

@kysrpex kysrpex added 🌱 new feature Solving the issue involves the incorporation of a new feature. and removed 💡 feature request labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👩‍🎓 newcomer task Issue that is a good entry point to the source code for a newcomer. 🌱 new feature Solving the issue involves the incorporation of a new feature. ⚡ breaking change Solution introduces incompatible API changes, MAJOR version number update. See https://semver.org.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pablo-de-andres @kysrpex @MBueschelberger @yoavnash