Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantum Espresso wrapper tutorial broken #66

Open
eudoxos opened this issue Dec 18, 2020 · 2 comments
Open

Quantum Espresso wrapper tutorial broken #66

eudoxos opened this issue Dec 18, 2020 · 2 comments
Labels
bug Something isn't working tutorials

Comments

@eudoxos
Copy link

eudoxos commented Dec 18, 2020

At this location, plus a few others at the same page:

"\u001b[0;31mTypeError\u001b[0m: _run() missing 1 required positional argument: 'simulation'"

@pablo-de-andres pablo-de-andres added bug Something isn't working tutorials labels Dec 18, 2020
@pablo-de-andres
Copy link
Member

pablo-de-andres commented Dec 18, 2020

@mathias-driesse could you take a look?
Also, I think it shouldn't be wrapper.session._run() but wrapper.session.run() (note the underscore). The user calls with run() method, _run() is used to call the syntactic layer.

Edit: ok, I see this is probably done because the default run() does not allow to provide any argument. This is because theoretically all the information should be encoded in cuds, and the wrapper would analyse them. That should be changed in a future release of the wrapper, but for now the most urgent task would be to fix the errors.

@pablo-de-andres pablo-de-andres added this to the v2.4.0 milestone Jan 19, 2021
@kysrpex kysrpex modified the milestones: v2.4.0, Sprint #1 Mar 29, 2021
@kysrpex kysrpex changed the title docs: TypeError: _run() missing 1 required positional argument: 'simulation' docs: Quantum Espresso wrapper tutorial broken Mar 29, 2021
@kysrpex kysrpex changed the title docs: Quantum Espresso wrapper tutorial broken Quantum Espresso wrapper tutorial broken Mar 29, 2021
@kysrpex kysrpex removed this from the Sprint #1 milestone Apr 12, 2021
@yoavnash
Copy link
Member

Hi @mathias-driesse, were you able to fix this eventually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tutorials
Projects
None yet
Development

No branches or pull requests

4 participants