Toast message has problems with umlauts

[bitwingsde]

Affected Version

5.1.0

Description

Toast-Message cannot display umlauts like "äöüÄÖÜß" correctly. See screenshot.

Affected location

GridFieldDetailForm_ItemRequest.php Line 543.
my temporary solution: 'type' => mb_convert_encoding($this->record->i18n_singular_name(), 'ISO-8859-1'),

Steps to Reproduce

Add title to data object and save.

PRs

• add missing rawurlencode #11105
• decode entities in toast message silverstripe-admin#1640

[lerni]

Umlauts show fine in SiteTree-"Toasts" but are scrambled with DOs per GF.

[lekoala]

In the same line, ' character is not working well either.

it seems that utf8 encoded characters are not being displayed properly

[lekoala]

I'm also a bit confused why the link creation is a direct call to htmlspecialchars instead of using the Convert class. It seems to be that either we use the Convert class or we don't, but mixing the two approaches is really odd.

silverstripe-framework/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php

Lines 552 to 576 in c003dfd

	$link = '<a href="' . $this->Link('edit') . '">"'
	. htmlspecialchars($this->record->Title ?? '', ENT_QUOTES)
	. '"</a>';
	$message = _t(
	'SilverStripe\\Forms\\GridField\\GridFieldDetailForm.Saved',
	'Saved {name} {link}',
	[
	'name' => $this->getModelName(),
	'link' => $link
	]
	);
	$form->sessionMessage($message, 'good', ValidationResult::CAST_HTML);
	$message = _t(
	__CLASS__ . '.SAVETOASTMESSAGE',
	'Saved {type} "{title}" successfully.',
	[
	'type' => $this->record->i18n_singular_name(),
	'title' => Convert::raw2xml($this->record->Title)
	]
	);
	$controller = $this->getToplevelController();
	$controller->getResponse()->addHeader('X-Status', $message);

[GuySartorelli]

Closing in favour of silverstripe/silverstripe-admin#1639 which has more information in it (and is against the correct repo)