FIX Don't log to the error handler (#11523)

Author: GuySartorelli

_config/logging.yml

@@ -16,14 +16,16 @@ SilverStripe\Core\Injector\Injector:
       pushDefaultLogger: [ pushLogger, [ '%$Psr\Log\LoggerInterface' ] ]
       pushErrorHandler: [ pushLogger, [ '%$Psr\Log\LoggerInterface.errorhandler' ] ]
 
-  # Default implementation for use as a standard logger. Up to developers to attach their own
-  # handlers
+  # Default implementation for use as a standard logger. Used for logging custom messages.
+  # Projects should attach log handlers to this logging service.
   Psr\Log\LoggerInterface:
     type: singleton
     class: Monolog\Logger
     constructor:
       - "error-log"
-  # Core error handling
+  # Core error handling - only uncaught exceptions and PHP errors should be caught by this handler.
+  # This handler displays those errors in the browser and CLI.
+  # Projects should not attach log handlers to this error handler service.
   Psr\Log\LoggerInterface.errorhandler:
     type: singleton
     class: Monolog\Logger

src/Security/Member.php

@@ -808,7 +808,7 @@ public function onBeforeWrite()
                 $email->send();
             } catch (TransportExceptionInterface | RfcComplianceException $e) {
                 /** @var LoggerInterface $logger */
-                $logger = Injector::inst()->get(LoggerInterface::class . '.errorhandler');
+                $logger = Injector::inst()->get(LoggerInterface::class);
                 $logger->error('Error sending email in ' . __FILE__ . ' line ' . __LINE__ . ": {$e->getMessage()}");
             }
         }

src/Security/MemberAuthenticator/LostPasswordHandler.php

@@ -256,7 +256,7 @@ protected function sendEmail($member, $token)
             return true;
         } catch (TransportExceptionInterface | RfcComplianceException $e) {
             /** @var LoggerInterface $logger */
-            $logger = Injector::inst()->get(LoggerInterface::class . '.errorhandler');
+            $logger = Injector::inst()->get(LoggerInterface::class);
             $logger->error('Error sending email in ' . __FILE__ . ' line ' . __LINE__ . ": {$e->getMessage()}");
             return false;
         }