Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Lua 5.4 so we're ready when it's released #668

Closed
3 tasks done
alerque opened this issue Oct 4, 2019 · 7 comments · Fixed by #929
Closed
3 tasks done

Test with Lua 5.4 so we're ready when it's released #668

alerque opened this issue Oct 4, 2019 · 7 comments · Fixed by #929
Labels
ci Continuous integration pipelines todo
Milestone

Comments

@alerque
Copy link
Member

alerque commented Oct 4, 2019

A beta release of Lua 5.4.0 has been announced.

  • Add it to our CI workflow so we know what's going on with it (as allow-fail)
  • Fix anything that doesn't run on it properly so there are no hiccups when it's released and people start having it show up as the Lua interpreter on their systems.
  • When we pass out tests on it, start making them required for new development work.

See also #606 for LuaJIT.

@alerque
Copy link
Member Author

alerque commented Jul 1, 2020

http://www.lua.org/versions.html#5.4

It's out.

@alerque
Copy link
Member Author

alerque commented Jul 3, 2020

This is currently blocking on lua-luaepnf/issues/4 at the least, possibly more...

@alerque
Copy link
Member Author

alerque commented Jul 8, 2020

Luaepnf solved with upstream release.

We're now hung up on bit32.

@alerque
Copy link
Member Author

alerque commented Jul 8, 2020

Looks like compat53 just got released which hopefully means a release for bit32 support is in the works.

@alerque
Copy link
Member Author

alerque commented Jul 8, 2020

Next up we're going to be stuck on lua-zlib.

@alerque
Copy link
Member Author

alerque commented Jul 8, 2020

That looks like the lot of them. Unfortunately lua-zlib isn't well maintained, we make have to fork that to get it up to speed. Also not up to speed with Lua 5.4 but if updating lua-zlib proves too painful we could look into lzlib.

@alerque
Copy link
Member Author

alerque commented Jul 18, 2020

That last PR took care of bit32, the final hold-out is lua-zlib. I've tested it with a fork and gotten it to work, but the upstream needs to release a new rockspec before we can reasonably start requiring it!

@alerque alerque added this to the v0.10.9 milestone Jul 20, 2020
@alerque alerque added the ci Continuous integration pipelines label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration pipelines todo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant