Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing siemens-ix.css does not result in the same style as splitting it up in siemens-ix-core.css and chosen themes #1523

Open
2 tasks done
Endunry opened this issue Oct 16, 2024 · 1 comment
Labels
triage We discuss this topic in our internal weekly wait for response Wait for author response

Comments

@Endunry
Copy link

Endunry commented Oct 16, 2024

Prerequisites

  • I have read the Contributing Guidelines.
  • I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?

I wanted to add a custom theme and followed the documentation as stated here
This resulted in a table not being displayed correctly, or the crucial part. Not in the same way which either means there is something wrong with the core-css, or the documentation is kind of misleading in that regard.

I created a simple stack-blitz here: https://stackblitz.com/edit/xnfrdi-ptmfn7?file=src%2Fstyles.css

Toggling between only the siemens-ix.css and the core + theme results in the table formatting differently.

@Endunry Endunry added the triage We discuss this topic in our internal weekly label Oct 16, 2024
@matthiashader
Copy link
Collaborator

Hello @Endunry.
In the core-css, the dependencies like bootstrap are not included, which is why the tables are not stylled correctly.
non-core: https://github.com/siemens/ix/blob/main/packages/core/scss/ix.scss
core: https://github.com/siemens/ix/blob/main/packages/core/scss/ix-core.scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage We discuss this topic in our internal weekly wait for response Wait for author response
Projects
None yet
Development

No branches or pull requests

2 participants