Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close event to ix-pane #1512

Open
2 tasks done
Aiderlei opened this issue Oct 11, 2024 · 1 comment
Open
2 tasks done

Add close event to ix-pane #1512

Aiderlei opened this issue Oct 11, 2024 · 1 comment
Labels
type: enhancement New feature or request Workflow: Issue created JIRA issue is created and will be analyzed

Comments

@Aiderlei
Copy link

Prerequisites

  • I have read the Contributing Guidelines.
  • I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

Suggestion / feature request

I suggest to add a click event binding when the 'x' or '>>' icons are clicked to close the currently expanded pane, e.g.

// angular template
<ix-pane-layout [variant]="variant" [layout]="layout" [borderless]="borderless">
  <ix-pane (close)="paneClosed()" heading="Pane Right" slot="right" size="33%">
    <p>This is the right pane.</p>
  </ix-pane>

  <div slot="content">
    // some content
  </div>
</ix-pane-layout>

// in the component code
paneClosed() {
  // stuff to do on pane closed, e.g. change url or deselect current row
}

This would allow to perform something right after the close action. In the current version there is only the expandedChanged event. It's event data provides not the sufficient details to decide whether the pane was closed by the pane close icon or not.

This are the actual icons:

image
image

@Aiderlei Aiderlei added triage We discuss this topic in our internal weekly type: enhancement New feature or request labels Oct 11, 2024
@danielleroux danielleroux added Workflow: Issue created JIRA issue is created and will be analyzed and removed triage We discuss this topic in our internal weekly labels Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

🤖 Hello @Aiderlei

Your issue will be analyzed and is part of our internal workflow.
To get informed about our workflow please checkout the Contributing Guidelines

JIRA: IX-1829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request Workflow: Issue created JIRA issue is created and will be analyzed
Projects
None yet
Development

No branches or pull requests

2 participants