Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Java 9 Modules #560

Open
manuel-mauky opened this issue Sep 18, 2018 · 1 comment
Open

Add Tests for Java 9 Modules #560

manuel-mauky opened this issue Sep 18, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@manuel-mauky
Copy link
Collaborator

In PR #555 an issue was fixed that prevented users from using mvvmFX in Java 9 Modules because the FxmlViewLoader was using an internal class to load resources.

What is missing is a unit-test that proves that this solution is working now and wasn't working beforhand. This is imporant to be safe with refactorings and new features in the future.

@manuel-mauky manuel-mauky added this to the 1.8.0 milestone Sep 18, 2018
@manuel-mauky manuel-mauky self-assigned this Sep 20, 2018
@manuel-mauky
Copy link
Collaborator Author

With #562 we have added a working example project for modules with Java 11. However, due to the fact that the core mvvmfx library is compiled with Java 8 (which won't be changed in the near future) it's not yet possible to include an automated test for this.

@manuel-mauky manuel-mauky modified the milestones: 1.8.0, 1.9.0 Dec 7, 2018
manuel-mauky added a commit that referenced this issue Mar 8, 2019
#560 remove circular dependency between jigsaw modules in example app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant