Cleanup tests #656
Merged
Cleanup tests #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTMjugador
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
I'm curious about how AI models like DALL·E, Stable Diffusion, or even DeepDream would perform in creating technically interesting test images... 😂
That aside, the changes look great, thanks! It's a bit sad to let some of the older test images go, but I agree they're probably no longer relevant for catching regressions. For any new testsuite images that aren't synthetic, we can always ask issue reporters to confirm their licensing from now on, too.
AlexTMjugador
force-pushed
the
cleanup-tests
branch
from
bcf741e to
2b7b9df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced a few tests with synthetic images and removed a number that I don't believe are relevant anymore.
I've also removed the #553 test without replacement as I don't know how to synthesise a replacement and the issue is still open anyway.
Going forward I think we should avoid adding any new "issue" tests and instead synthesise something suitable in one of the other collections.
Closes #655.