Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md for Options #202

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Updated README.md for Options #202

merged 2 commits into from
Mar 20, 2024

Conversation

fishonamos
Copy link
Contributor

Improved grammar and readability in documentation for Option type usage and applications"

Improved grammar and readability in documentation for `Option` type usage and applications"
@shramee shramee closed this Mar 20, 2024
@shramee shramee reopened this Mar 20, 2024
Copy link
Owner

@shramee shramee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, some markup to highlight language keywords without changing the sentences themselves could be helpful here.

@fishonamos
Copy link
Contributor Author

fishonamos commented Mar 20, 2024 via email

I removed the sentence structure changes and left only the markup to highlight language keywords.
@fishonamos
Copy link
Contributor Author

Hi @shramee . I have removed the sentences changes. Only the markup highlight for the language keywords are left.

@shramee shramee self-requested a review March 20, 2024 17:18
@shramee
Copy link
Owner

shramee commented Mar 20, 2024

Thanks @fishonamos This makes it much easier to read!
We are not yet sure if we want to keep these readmes but I'll merge it for now.

@shramee shramee merged commit 276859e into shramee:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants