Skip to content

Commit a29cd8f

Browse files
committed
Merge branch 'cleanup-files' into main
2 parents c0917fc + 6367696 commit a29cd8f

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

app/src/main/java/dev/shorthouse/coinwatch/navigation/AppNavHost.kt

+9-2
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ package dev.shorthouse.coinwatch.navigation
22

33
import androidx.compose.animation.EnterTransition
44
import androidx.compose.animation.ExitTransition
5+
import androidx.compose.animation.core.tween
6+
import androidx.compose.animation.fadeIn
7+
import androidx.compose.animation.fadeOut
58
import androidx.compose.runtime.Composable
69
import androidx.navigation.NavHostController
710
import androidx.navigation.compose.NavHost
@@ -21,10 +24,14 @@ fun AppNavHost(navController: NavHostController = rememberNavController()) {
2124
enterTransition = { EnterTransition.None },
2225
exitTransition = { ExitTransition.None }
2326
) {
24-
composable(Screen.NavigationBar.route) {
27+
composable(route = Screen.NavigationBar.route) {
2528
NavigationBarScaffold(onNavigateDetails = onNavigateDetails)
2629
}
27-
composable(route = Screen.Details.route + "/{coinId}") {
30+
composable(
31+
route = Screen.Details.route + "/{coinId}",
32+
enterTransition = { fadeIn(animationSpec = tween(700)) },
33+
exitTransition = { fadeOut(animationSpec = tween(700)) }
34+
) {
2835
CoinDetailsScreen(onNavigateUp = { navController.navigateUp() })
2936
}
3037
}

app/src/main/java/dev/shorthouse/coinwatch/ui/screen/favourites/FavouritesScreen.kt

+3-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ fun FavouritesScreen(
4545
onCoinClick = { coin ->
4646
onNavigateDetails(coin.id)
4747
},
48-
onRefresh = { viewModel.initialiseUiState() }
48+
onRefresh = {
49+
viewModel.initialiseUiState()
50+
}
4951
)
5052
}
5153

app/src/main/java/dev/shorthouse/coinwatch/ui/screen/market/MarketScreen.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ fun MarketScreen(
115115
)
116116
val showJumpToTopFab by remember {
117117
derivedStateOf {
118-
lazyListState.firstVisibleItemIndex > 0
118+
lazyListState.firstVisibleItemIndex > 1
119119
}
120120
}
121121

app/src/main/java/dev/shorthouse/coinwatch/ui/screen/market/MarketViewModel.kt

+8
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,18 @@ class MarketViewModel @Inject constructor(
114114
}
115115

116116
fun updateShowCoinSortBottomSheet(showSheet: Boolean) {
117+
if (showSheet && isAnyBottomSheetOpen()) return
118+
117119
_uiState.update { it.copy(showCoinSortBottomSheet = showSheet) }
118120
}
119121

120122
fun updateShowCoinCurrencyBottomSheet(showSheet: Boolean) {
123+
if (showSheet && isAnyBottomSheetOpen()) return
124+
121125
_uiState.update { it.copy(showCoinCurrencyBottomSheet = showSheet) }
122126
}
127+
128+
private fun isAnyBottomSheetOpen(): Boolean {
129+
return _uiState.value.showCoinSortBottomSheet || _uiState.value.showCoinCurrencyBottomSheet
130+
}
123131
}

0 commit comments

Comments
 (0)