Skip to content
This repository has been archived by the owner on Dec 27, 2020. It is now read-only.

Migrate graceful shutdown into app framework #67

Open
alldroll opened this issue Feb 27, 2020 · 0 comments · May be fixed by #101
Open

Migrate graceful shutdown into app framework #67

alldroll opened this issue Feb 27, 2020 · 0 comments · May be fixed by #101
Assignees
Labels
enhancement New feature or request

Comments

@alldroll
Copy link
Contributor

From https://cloud.google.com/blog/products/gcp/kubernetes-best-practices-terminating-with-grace

It's important that an application handles termination gracefully so that there is minimal impact on the end-user and the time-to-recovery is as fast as possible! In practice, this means your application needs to handle the SIGTERM message and begin shutting down when it receives it. This means saving all data that needs to be saved, closing down network connections, finishing any work that is left, and other similar tasks

We have already implemented this feature here. It is time to migrate this feature into app framework in order to provide graceful shutdown for other services.

@magicoder10 magicoder10 added the enhancement New feature or request label Mar 9, 2020
@magicoder10 magicoder10 assigned arberiii and unassigned alldroll Apr 19, 2020
@arberiii arberiii linked a pull request May 27, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants