-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonic imports of shogun #4990
Comments
Merged
which files are left? |
please find out yoursef. that is part of the task |
mohitmajithia
added a commit
to mohitmajithia/shogun
that referenced
this issue
May 4, 2020
made changes in this file shogun-toolbox#4990
Closed
mohitmajithia
added a commit
to mohitmajithia/shogun
that referenced
this issue
May 4, 2020
Closed
i am beginner how can i solve my first issue |
Hello, I tried solving this issue in some of the files which I have found but I don't know why it is not passing the checks in my pull request #5156. Can you help me with that why it is happening? |
can i work on this issue?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to replace imports in the lines of
from shogun import *
from shogun import features
with
import shogun as sg
, and then call shogun methods with that handle, i.e.sg.features
instead of justfeatures
This is as the number of names of shogun API objects that clash with potential variable names (features) is growing and we want to avoid confusion.
This needs to be done in (in order of priority)
meta examples (seeexamples/meta/generator/targets/python.json
)The text was updated successfully, but these errors were encountered: