-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using two different bodyElements, the zeroElement is reused between them causing position to be completely off #907
Comments
neryams
changed the title
When using two different bodyElements, the nullElement is reused between them causing position to be completely off
When using two different bodyElements, the zeroElement is reused between them causing position to be completely off
Oct 5, 2021
@neryams thanks for reporting this issue. Would you be able to open a PR with a fix? |
Here's a fork of the stackblitz with the edits in the PR to tether: https://stackblitz.com/edit/web-platform-qspqru?file=tether.js Thanks! |
I can confirm, that @neryams changes fix the issue. @RobbieTheWagner would be great if you could have a look at this. |
borisdiakur
added a commit
to emdgroup-liquid/liquid
that referenced
this issue
Apr 3, 2023
References: - #609 - #452 - shipshapecode/tether#907
10 tasks
borisdiakur
added a commit
to emdgroup-liquid/liquid
that referenced
this issue
Apr 3, 2023
References: - #609 - #452 - shipshapecode/tether#907
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This may be related to #279.
See example: https://stackblitz.com/edit/web-platform-xvi6jy?file=script.js
To reproduce, click on the left red box, then click on the right red box. Note that the positions are correct. Now clicking on the left red box again will cause the popup to be placed incorrectly.
The zeroElement in the container is being reused for calculations on the html body element in bounds.js
The text was updated successfully, but these errors were encountered: