Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misskey_page_page.dartにページURLをコピーするボタンを追加 #700

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Npepperlinux
Copy link
Contributor

Resolve #698
ページのリンクを追加しました。
Related to #680
リンクのコピーボタンのアイコンをlinkに変更しました。
Screenshot from 2024-11-29 19-22-09

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 27.54%. Comparing base (cb8696b) to head (ef4f23b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/view/misskey_page_page/misskey_page_page.dart 0.00% 38 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #700      +/-   ##
===========================================
- Coverage    27.59%   27.54%   -0.06%     
===========================================
  Files          312      312              
  Lines        16454    16486      +32     
===========================================
  Hits          4541     4541              
- Misses       11913    11945      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4ster1sk
Copy link
Contributor

ブラウザで開くも上部に持ってきて、ページタイトルの下あたりに配置するとチャンネルと同じ感じのレイアウトになってわかりやすいのかもなあと思ったりはする。

@Npepperlinux
Copy link
Contributor Author

ブラウザで開くも上部に持ってきて、ページタイトルの下あたりに配置するとチャンネルと同じ感じのレイアウトになってわかりやすいのかもなあと思ったりはする。

ブログやニュース記事だとページタイトル下と本文下に共有ボタンを置いていることがあるけど、それと同じような形でリンクコピーボタンとブラウザで開くボタンを2つ置いても良さそう?

@Npepperlinux
Copy link
Contributor Author

9918f0f 時点の状態
Screenshot from 2024-12-01 01-58-27
Screenshot from 2024-12-01 01-58-43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

「ページのリンクをコピー」ボタンを追加
3 participants