Various improvements to DSL #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves `asAcDSLOperandList` up to `Object` to make automagic conversion of values working for one-operand instructions too.
This method has to `#asAcDSLOperand` to make sure elements are DSL operands!
`String >> #asAcDSLOperandList` has to return an operand list with single
element of `AcDSLSymbol` - this is to make strings usable as symbols when
generating for example labels:
asm
label:'func';
...
To do so we have to override (inherited) implementation from
`SequenceableCollection`.
This commit move `cursor` (an index into instruction sequence marking where generates instructions are going to be inserted) from code buffer to (DSL) assembler. This seems to make sense as the code buffer is (now) merely a container for instructions. This will become more apparent later when we extend code buffer into more simplified object file-like structure.
The latter - `AcDSLCodeObject` - seems to be a better name of what this really is (or will become in subsequent commit) as it's more like an "object file" (or "object code") than mere memory buffer containing instructions. It has base address, (will) contains relocations, debug info and what not so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's another bunch of minor improvements to ArchC-DSL that accumulated when working on relocations but not really specific to them.