Implement any-length BitVectors #335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caveat programmator: I am using the names #with: and #v, trying to avoid #value: and #value because along the progress of MachineArithmetic I increasingly feel the fake-polymorphism with function-application will become extremely dangerous.
Convenient notation consistent with Z3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address #334. The idea is to have a pre-sort standing somewhere between actual bitvector sorts (of known length) and type variables. At Sprite-level elaboration, unification will "assign" concrete lengths to them (similar to how concrete sorts are assigned to type variables), so the VC level does not see them at all (in other words, the whole concept just does not exist in Fixpoint).